Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default Python version to 3.7 #19317

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 29, 2021

Continuation of #18922

This case was missed and is needed to have correct image tagged for Docker Hub


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Continuation of apache#18922

This case was missed and is needed to have correct image tagged for Dockerfiles
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 29, 2021
@kaxil kaxil closed this Oct 29, 2021
@kaxil kaxil reopened this Oct 29, 2021
@kaxil kaxil merged commit 98d9067 into apache:main Oct 30, 2021
@kaxil kaxil deleted the update-default-version branch October 30, 2021 00:16
@kaxil kaxil added this to the Airflow 2.2.2 milestone Oct 30, 2021
potiuk added a commit to potiuk/airflow that referenced this pull request Oct 30, 2021
After seting 3.7 the default (apache#19317) the warning printed by
Python during importing all providers (specifically apache beam)
has slightly changed. Apparently collections.abc warning was
a bit more "scary" - warning that it's 3.9 not 3.10 where the
old collection imports will stop working (Note that actually
this did not happen even in 3.10, apparently)

This PR fixes the "known" warning message to match it but also
a separate PR (apache/beam#15850) was
opened to Beam to get rid of the warnings altogether.

Also seems 'dns` stopped generating this warning so I removed it
and in case warnings are generated, they are printed outside of
the folded group, so that it's immediately visible.
potiuk added a commit that referenced this pull request Oct 31, 2021
After seting 3.7 the default (#19317) the warning printed by
Python during importing all providers (specifically apache beam)
has slightly changed. Apparently collections.abc warning was
a bit more "scary" - warning that it's 3.9 not 3.10 where the
old collection imports will stop working (Note that actually
this did not happen even in 3.10, apparently)

This PR fixes the "known" warning message to match it but also
a separate PR (apache/beam#15850) was
opened to Beam to get rid of the warnings altogether.

Also seems 'dns` stopped generating this warning so I removed it
and in case warnings are generated, they are printed outside of
the folded group, so that it's immediately visible.
jedcunningham pushed a commit that referenced this pull request Nov 3, 2021
Continuation of #18922

This case was missed and is needed to have correct image tagged for Dockerfiles

(cherry picked from commit 98d9067)
This was referenced Nov 30, 2021
potiuk added a commit to potiuk/airflow that referenced this pull request Nov 30, 2021
This PR enables mypy back as pre-commit for local changes after
the apache#19317 switched to Python 3.7 but also it separates out
mypy to a separate non-failing step in CI.

In the CI we will be able to see remaining mypy errors.

This will allow us to gradually fix all the mypy errors and enable
mypy back when we got all the problems fixed.
potiuk added a commit to potiuk/airflow that referenced this pull request Nov 30, 2021
In order to keep consistency, both mypy and flake were always
using Python 3.6 - simply to make sure that the same errors
are produced for everyone. When default python version was
changed in apache#19317 the regular PR static checks started to fail
because Python 3.6 image is no longer built for "regular" PRs
(it's only built when "full-tests-needed" is set or when
the build runs in "main" as result of push or schedule).

Unfortunately those "defaults" could not be read from
"default python version" easily, because they are also
executed in pre-commits, which do not have the same
initialization as `breeze` or other CI scripts so there
are literally 3 more places where Python 3.6 should be
changed to 3.7.

This PR fixes it.
potiuk added a commit that referenced this pull request Nov 30, 2021
This PR enables mypy back as pre-commit for local changes after
the #19317 switched to Python 3.7 but also it separates out
mypy to a separate non-failing step in CI.

In the CI we will be able to see remaining mypy errors.

This will allow us to gradually fix all the mypy errors and enable
mypy back when we got all the problems fixed.
potiuk added a commit that referenced this pull request Jan 22, 2022
After seting 3.7 the default (#19317) the warning printed by
Python during importing all providers (specifically apache beam)
has slightly changed. Apparently collections.abc warning was
a bit more "scary" - warning that it's 3.9 not 3.10 where the
old collection imports will stop working (Note that actually
this did not happen even in 3.10, apparently)

This PR fixes the "known" warning message to match it but also
a separate PR (apache/beam#15850) was
opened to Beam to get rid of the warnings altogether.

Also seems 'dns` stopped generating this warning so I removed it
and in case warnings are generated, they are printed outside of
the folded group, so that it's immediately visible.

(cherry picked from commit 4bb1317)
jedcunningham pushed a commit that referenced this pull request Jan 27, 2022
After seting 3.7 the default (#19317) the warning printed by
Python during importing all providers (specifically apache beam)
has slightly changed. Apparently collections.abc warning was
a bit more "scary" - warning that it's 3.9 not 3.10 where the
old collection imports will stop working (Note that actually
this did not happen even in 3.10, apparently)

This PR fixes the "known" warning message to match it but also
a separate PR (apache/beam#15850) was
opened to Beam to get rid of the warnings altogether.

Also seems 'dns` stopped generating this warning so I removed it
and in case warnings are generated, they are printed outside of
the folded group, so that it's immediately visible.

(cherry picked from commit 4bb1317)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants